Skip to content

Feat: syntax validation level for Lua EEPs#6494

Merged
rudrakhp merged 1 commit intoenvoyproxy:mainfrom
rudrakhp:lua_syntax_validation
Jul 10, 2025
Merged

Feat: syntax validation level for Lua EEPs#6494
rudrakhp merged 1 commit intoenvoyproxy:mainfrom
rudrakhp:lua_syntax_validation

Conversation

@rudrakhp
Copy link
Member

@rudrakhp rudrakhp commented Jul 9, 2025

What type of PR is this?

Feat: syntax validation level for Lua EEPs

What this PR does / why we need it:
Introduce syntax validation level for Lua in EnvoyExtensionPolicies to allow for usage of external libraries and still have basic validation in place.

Which issue(s) this PR fixes:

Related discussion in Slack thread
Related: #6172 #6176 #6355

Release Notes: Yes

@rudrakhp rudrakhp requested a review from a team as a code owner July 9, 2025 17:50
@rudrakhp rudrakhp added this to the v1.5.0-rc.1 Release milestone Jul 9, 2025
@rudrakhp rudrakhp requested a review from arkodg July 9, 2025 17:57
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (9d2b27d) to head (434cc27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6494      +/-   ##
==========================================
+ Coverage   70.63%   70.69%   +0.05%     
==========================================
  Files         220      220              
  Lines       37686    37701      +15     
==========================================
+ Hits        26621    26651      +30     
+ Misses       9500     9485      -15     
  Partials     1565     1565              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge L35 and L36 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing change to release notes, L35 is generic enough to include L36.

arkodg
arkodg previously approved these changes Jul 9, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team July 9, 2025 19:05
@rudrakhp rudrakhp requested a review from arkodg July 9, 2025 19:18
arkodg
arkodg previously approved these changes Jul 9, 2025
@arkodg arkodg requested review from a team July 9, 2025 19:19
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
@rudrakhp rudrakhp merged commit e8fefff into envoyproxy:main Jul 10, 2025
31 checks passed
tjvdmolen pushed a commit to tjvdmolen/gateway that referenced this pull request Jul 11, 2025
feat: syntax validation level for Lua EEPs

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Signed-off-by: Tjeerd Jan van der Molen <34071+tjvdmolen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants